Remove stale r_gltfGpuTangentFix; simplify glTF GPU vertex shaders#172
Merged
cursor[bot] merged 1 commit intomainfrom May 4, 2026
Merged
Remove stale r_gltfGpuTangentFix; simplify glTF GPU vertex shaders#172cursor[bot] merged 1 commit intomainfrom
cursor[bot] merged 1 commit intomainfrom
Conversation
The cvar defaulted to 1 and only selected a legacy bind-pose tangent shader variant. Drop the toggle, Vk_Pipeline_Def field, and duplicate glTF GPU vertex SPIR-V variants; compile_shaders now emits only the GLTF_GPU_TANGENT_FIX path. Regenerated shader blobs and bindings. Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flags removed
r_gltfGpuTangentFix(Vulkan renderer cvar)Why this is safe to delete
1; documentation described0as a legacy bind-pose-only tangent path that diverged from the intended PBR GPU behavior.GLTF_GPU_TANGENT_FIX(Gram–Schmidt T vs deformed N).Vk_Pipeline_Def.gltf_gpu_tangent_fixupwas removed so pipeline dedup (memcmpon defs) no longer depends on a user toggle.Implementation notes
scripts/compile_shaders.sh: glTF GPU vertex variants no longer compile a_tfix/ non-fix pair; only the fix-enabled variant is emitted.vk.modules.vert.gen_gltf_gpuis now[2][3][2][2][2](one module per combo);vk_create_pipeline.candvk_shutdown.cupdated accordingly.shader_data.c/shader_binding.c(committed +spirv/generated/copies).Behavioral parity checks performed
./scripts/compile_engine.sh vulkan(Release) — successctestinbuild-vk-Release(19 tests includingsmoke_test,renderer_regression_check) — all passedFollow-up (optional)
docs/GLTF.md,docs/GLTF_GPU_UPLOAD.md, anddocs/ROADMAP.mdstill mentionr_gltfGpuTangentFix; update in a separate doc pass if desired.