Update @snoop_inference for Julia 1.12
#419
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This depends on changes to Julia
vtjnash
reviewed
Apr 15, 2025
| const newly_inferred = CodeInstance[] | ||
|
|
||
| function start_tracking() | ||
| islocked(snoop_inference_lock) && error("already tracking inference (cannot nest `@snoop_inference` blocks)") |
There was a problem hiding this comment.
(this really should be a Base feature, since implementing it indirectly in packages is not very robust)
Suggested change
| islocked(snoop_inference_lock) && error("already tracking inference (cannot nest `@snoop_inference` blocks)") | |
| snoop_inference_lock.reentrancy_cnt == 1 || throw(ConcurrencyViolationError("already tracking inference (cannot nest `@snoop_inference` blocks)")) |
vtjnash
reviewed
Apr 15, 2025
| finish_snoop_inference() | ||
| end | ||
| function stop_tracking() | ||
| @assert islocked(snoop_inference_lock) |
There was a problem hiding this comment.
nit: more concisely and correctly
Suggested change
| @assert islocked(snoop_inference_lock) | |
| Base.assert_havelock(snoop_inference_lock) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leverages the new timing fields of
CodeInstanceto replace the oldCore.Compiler.Timingsmodule. There is a bit of loss particularly in the domain of constant-propagation, which is illustrated in https://gist.github.com/timholy/9a64b27c1932bb414e69b8fe48284b5e. (Readtestcase.jlbefore looking at the results.) As a consequence there are a small handful of failing tests locally, but the vast majority pass.This requires JuliaLang/julia#58124 or alternatively (with some modification to this PR) JuliaLang/julia#58123.