Apiv3 #206
Merged
Apiv3 #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoschlueter
requested changes
Nov 13, 2025
Owner
timoschlueter
left a comment
timoschlueter
left a comment
There was a problem hiding this comment.
Looks good! Just see my comment regarding the DEVICE_NAME. We can merge your code into version 3.1.0 :)
timoschlueter
approved these changes
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Im using the script only. Please let me know if there are any UI parts that you would like to also be updated.
I changed the device to include the sensor itself based on my inspection of NS test code:
https://github.com/nightscout/cgm-remote-monitor/blob/91cd601038a3bce00f92655cc6b1cc02fa3589d3/tests/pebble.test.js#L23