Conversation
There was a problem hiding this comment.
Pull request overview
This pull request modernizes the mypy testing infrastructure by replacing the mypy-specific .test data-driven test format with standard pytest test functions that invoke mypy manually. The change simplifies test authoring and improves test execution speed by sharing a common mypy cache directory across tests.
Changes:
- Upgraded mypy from version 1.15.0 to 1.19.1 with new dependencies (librt, pathspec)
- Replaced mypy data-driven test framework with custom mypy_helper.py module for manual mypy invocation
- Converted 10 .test files to standard Python pytest files with clearer test structure
- Modified CI workflow to run on ubuntu-latest instead of windows-latest and added color output
- Refactored test fixtures to use session-scoped JVM and stub generation for performance
Reviewed changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Updated mypy to 1.19.1 and added new dependencies (librt 0.8.0, pathspec 1.0.4) with metadata updates |
| tests/mypy_helper.py | New helper module for running mypy programmatically and validating output against expected markers |
| tests/conftest.py | Refactored fixtures to use session scope for JVM startup and stub generation; removed mypy test plugin dependency |
| tests/test_*.py (10 files) | Converted from .test format to standard pytest functions with marker-based assertions |
| tests/stubtest/test-data/unit/*.test (10 files) | Deleted old data-driven test files |
| tests/stubtest/README.md | Removed as no longer needed without data-driven tests |
| tests/test_stubtest.py | Deleted old test suite runner |
| pyproject.toml | Updated mypy version specification from 1.15.0 to 1.19.1 |
| .github/workflows/python-package.yml | Changed runner from windows-latest to ubuntu-latest and added FORCE_COLOR environment variable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call mypy manually instead of using the mypy specific
.testfiles. The.testfiles was to complicated to use.Additionaly this speeds up the tests by sharing the mypy_cache folder