Skip to content

Fix chaquopy types#2

Merged
timrid merged 7 commits intomainfrom
fix-chaquopy-types
Feb 16, 2026
Merged

Fix chaquopy types#2
timrid merged 7 commits intomainfrom
fix-chaquopy-types

Conversation

@timrid
Copy link
Copy Markdown
Owner

@timrid timrid commented Feb 16, 2026

Some of the chaquopy types are wrong an now corrected plus tests are added for them.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects Chaquopy-related type stubs (notably proxy/decorator and primitive types) and adds mypy-based regression tests to validate the improved typing behavior.

Changes:

  • Tighten typing for static_proxy, constructor, method, and Override in the generated Chaquopy bindings.
  • Improve primitive stub typing (e.g., value attributes and dunder return types) and add mypy tests covering primitives, casts/jclass, exceptions, and static proxies.
  • Enhance mypy test helper assertions for clearer failures and stricter message matching.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/chaquopy_stubgen/chaquopy_bindings.py Updates generated Chaquopy .pyi signatures for proxies/decorators and primitive types.
tests/mypy_helper.py Improves assertion diagnostics and validates message counts when comparing mypy output.
tests/test_static_proxy.py Adds mypy tests for correct and incorrect static_proxy/decorator type usage.
tests/test_primitives.py Adds mypy tests for primitive constructors, .value types, and overload resolution.
tests/test_exception.py Adds mypy test ensuring Java exceptions are compatible with builtins.Exception.
tests/test_chaquopy.py Adds mypy tests for cast and jclass typing.
README.md Updates CLI usage examples to use uv run.
.vscode/launch.json Updates debug configuration name/args to match current repo paths.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/mypy_helper.py
Comment thread README.md Outdated
@timrid timrid force-pushed the fix-chaquopy-types branch from 940b950 to 134365a Compare February 16, 2026 20:29
@timrid timrid force-pushed the fix-chaquopy-types branch from 134365a to 1c19931 Compare February 16, 2026 20:34
@timrid timrid merged commit 7309f79 into main Feb 16, 2026
1 check passed
@timrid timrid deleted the fix-chaquopy-types branch February 16, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants