Conversation
There was a problem hiding this comment.
Pull request overview
This PR corrects Chaquopy-related type stubs (notably proxy/decorator and primitive types) and adds mypy-based regression tests to validate the improved typing behavior.
Changes:
- Tighten typing for
static_proxy,constructor,method, andOverridein the generated Chaquopy bindings. - Improve primitive stub typing (e.g.,
valueattributes and dunder return types) and add mypy tests covering primitives, casts/jclass, exceptions, and static proxies. - Enhance mypy test helper assertions for clearer failures and stricter message matching.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/chaquopy_stubgen/chaquopy_bindings.py |
Updates generated Chaquopy .pyi signatures for proxies/decorators and primitive types. |
tests/mypy_helper.py |
Improves assertion diagnostics and validates message counts when comparing mypy output. |
tests/test_static_proxy.py |
Adds mypy tests for correct and incorrect static_proxy/decorator type usage. |
tests/test_primitives.py |
Adds mypy tests for primitive constructors, .value types, and overload resolution. |
tests/test_exception.py |
Adds mypy test ensuring Java exceptions are compatible with builtins.Exception. |
tests/test_chaquopy.py |
Adds mypy tests for cast and jclass typing. |
README.md |
Updates CLI usage examples to use uv run. |
.vscode/launch.json |
Updates debug configuration name/args to match current repo paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
940b950 to
134365a
Compare
134365a to
1c19931
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the chaquopy types are wrong an now corrected plus tests are added for them.