Skip to content

iOS infinite loop patch #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

iOS infinite loop patch #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b74113
Update index.ts
khmyznikov May 20, 2018
2bbb862
Declare _cleanup as public method
khmyznikov May 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ function onTouchstart( e:TouchEvent ) {
// only allow one drag operation at a time
if( activeDragOperation ) {
console.log( "dnd-poly: drag operation already active" );
// try avoid infinite loop on iOS if something happened with draggable dom object (disappeared or changed during drag)
activeDragOperation._cleanup();
return;
}

Expand Down
2 changes: 1 addition & 1 deletion src/internal/drag-operation-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ export class DragOperationController {
return true;
}

private _cleanup() {
public _cleanup() {

console.log( "dnd-poly: cleanup" );

Expand Down