fix: count days (d) unit in parse_duration - #108
Open
tmmt-agent wants to merge 1 commit into
Open
tmmt-agent wants to merge 1 commit into
tmmt-agent wants to merge 1 commit into
Conversation
The _UNITS dictionary was missing the 'd' key, so parse_duration
silently dropped the days unit (e.g. parse_duration('1d') returned 0
instead of 86400). The token regex already matched 'd' in [wdhms],
but the value was never added to the total.
- Add 'd': 86400 to _UNITS
- Update comment to list days as supported
- Add test_days and test_days_combined test cases
Fixes: tine1117#1
tmmt-agent
force-pushed
the
fix/parse-duration-days
branch
from
July 27, 2026 16:20
a56fd90 to
7411ab1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
parse_durationfunction was missing thed(days) unit in its regex token pattern, causing duration strings like"1d"or"2d12h"to raiseValueError.Changes
dto the_TOKENregex pattern:(\d+)([wdhms])→(\d+)([wdhms])"d": 86400to the_UNITSdictionarytest_days)Testing
All 8 unit tests pass, including the new
test_dayscase.