Conversation
The _UNITS dictionary was missing the 'd' entry for days, causing parse_duration to silently skip day tokens (consuming them from the input but contributing 0 to the total). Added 'd': 86400 and updated the comment. Fixed a typo in the combined test's expected value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
parse_durationsilently drops the'd'(days) unit — the_TOKENregex acceptsdbut the_UNITSdict lacks a"d": 86400entry, so theif unit in _UNITSguard skips day tokens entirely. They get consumed from the input (noValueError), but contribute 0 to the total.Fix
Added
"d": 86400to_UNITSinduration_utils.pyand updated the comment to list days as a supported unit.Testing
python -m unittest discover -s tests→ 13/13 OK.Fixes #1