Conversation
The README lists 'd' as a supported unit but the parser silently dropped it, returning 0 for '1d' and wrong results for compound durations like '2d4h'. Added 'd' = 86400 seconds to _UNITS and added test coverage for days and combined durations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README lists
das a supported unit but the parser silently dropped it, returning 0 for1dand wrong results for compound durations like2d4h.Fix: added
d: 86400to the_UNITSdict induration_utils.py.Tests added:
test_days: verifies1d == 86400,2d == 172800test_combined_with_days: verifies2d4h == 187200and1w2d3h4m5s == 788645All 9 tests pass.
Closes #1