Conversation
parse_duration silently dropped the days unit because 'd' was matched by the token regex but not present in the _UNITS dictionary. - Added 'd': 86400 to _UNITS - Added test_days and test_days_combined tests Closes tine1117#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_durationsilently dropped thed(days) unit because it was matched by the token regex but not present in the_UNITSdictionary.Changes
"d": 86400to_UNITSinduration_utils.pytest_daysandtest_days_combinedtest casesVerification
All 9 tests pass:
Closes #1