fix: add days (d) unit to parse_duration - #122
Closed
WNordbergg wants to merge 1 commit into
Closed
WNordbergg wants to merge 1 commit into
WNordbergg wants to merge 1 commit into
Conversation
The _UNITS dict was missing the entry for days while the token regex already accepted 'd', so day values were silently dropped. - add "d": 86400 to _UNITS - regression tests: test_days, test_days_combined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #120
Problem
parse_durationsilently dropped day (d) values: the token regex accepteddbut_UNITShad no entry for it, soparse_duration("1d")returned 0.Change
"d": 86400to_UNITSinduration_utils.pytest_days(1d-> 86400) andtest_days_combined(2d12h-> 216000)Verification
Full suite: 9 tests, all passing (7 pre-existing + 2 new).