chore: bump openai #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="update_openai.sh">
<violation number="1" location="update_openai.sh:4">
P1: Missing validation for `LATEST_TAG`. If the curl request fails or returns unexpected JSON, the variable could be empty or 'null', corrupting Package.swift. Add validation before proceeding.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| #!/bin/bash | ||
| set -e | ||
|
|
||
| LATEST_TAG=$(curl -sL https://api.github.com/repos/MacPaw/OpenAI/releases/latest | jq -r ".tag_name") |
There was a problem hiding this comment.
P1: Missing validation for LATEST_TAG. If the curl request fails or returns unexpected JSON, the variable could be empty or 'null', corrupting Package.swift. Add validation before proceeding.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At update_openai.sh, line 4:
<comment>Missing validation for `LATEST_TAG`. If the curl request fails or returns unexpected JSON, the variable could be empty or 'null', corrupting Package.swift. Add validation before proceeding.</comment>
<file context>
@@ -0,0 +1,12 @@
+#!/bin/bash
+set -e
+
+LATEST_TAG=$(curl -sL https://api.github.com/repos/MacPaw/OpenAI/releases/latest | jq -r ".tag_name")
+
+echo "OpenAI package latest version: $LATEST_TAG"
</file context>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Pin the OpenAI Swift package to v0.4.7 to avoid breakages from upstream changes and ensure reproducible builds. Added a small script to bump the dependency to the latest release when needed.
Written for commit deed59c. Summary will update automatically on new commits.