fix: upgrade go-lucene to v0.2.1 and consolidate pending dependency + CI-hardening upgrades - #217
Conversation
…ection, go-lucene#59)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… 1.44) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 44 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR pins GitHub Actions to immutable commit SHAs, updates the golangci-lint version, refreshes Go dependencies, and changes telemetry tests to use OpenTelemetry attribute string conversion. ChangesGitHub Actions pinning
Go dependency refresh
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 43-45: Add persist-credentials: false to both checkout steps in
.github/workflows/ci.yml at lines 43-45 and 77-79, covering the lint and test
jobs while preserving their existing fetch-depth settings.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9340683e-cfd3-4a74-876b-f794e5c32ef9
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (5)
.github/workflows/ci.yml.github/workflows/release.ymlgo.modobservability/resource_test.gostorage/telemetry_test.go
Lutherwaves
left a comment
There was a problem hiding this comment.
Allchanges are trivial and verified
Consolidated dependency + CI-hardening upgrade, baked off fresh
main.What's included
fix(mql): go-lucene v0.2.0 → v0.2.1 — fixes go-lucene#59 (backslash-escaped quote inside a phrase breaks the phrase early → query injection). This is the semantic-release driver.chore(deps): minor group (supersedes chore(deps): bump the minor group across 1 directory with 13 updates #216) — azcore 1.22.0, azidentity 1.14.0, azcosmos 1.5.0, aws sns 1.41.1, otel contrib/runtime 0.69.0, otlp{metricgrpc,trace,tracegrpc} 1.44.0 (otel core co-bumped to 1.44 via MVS lockstep).fix(telemetry): OTel 1.44 deprecation —attribute.Value.Emit()→.String()in two test files. This is why chore(deps): bump the minor group across 1 directory with 13 updates #216's CI was red: magic has no local golangci config, so CI lints with default linters (staticcheck ON) andSA1019failed the build. Behavior-preserving.ci: SHA-pin remaining GitHub Actions + pin golangci-lint — ci.yml (webiny v1.4.2, checkout v7.0.0, setup-go v6.4.0, golangci-lint-action v9.3.0) and release.yml (go-semantic-release v1.24.1) pinned to commit SHAs; golangci-lintversion: latest→v2.12.2to stop linter drift.Verification
GOWORK=offbuild + test +golangci-lint run --no-config(staticcheck ON, CI-representative) all green — 0 lint issues.Merge note
Squash-merge keeping the
fix:subject sogo-semantic-releasecuts the tag (~v0.18.x). Supersedes #216 (close on merge) — the dependabot grouping config is already onmain.Summary by CodeRabbit
Chores
Tests