Skip to content

fix: upgrade go-lucene to v0.2.1 and consolidate pending dependency + CI-hardening upgrades - #217

Merged
Lutherwaves merged 5 commits into
mainfrom
chore/consolidated-deps-vnext
Jul 15, 2026
Merged

fix: upgrade go-lucene to v0.2.1 and consolidate pending dependency + CI-hardening upgrades#217
Lutherwaves merged 5 commits into
mainfrom
chore/consolidated-deps-vnext

Conversation

@Lutherwaves

@Lutherwaves Lutherwaves commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Consolidated dependency + CI-hardening upgrade, baked off fresh main.

What's included

  • fix(mql): go-lucene v0.2.0 → v0.2.1fixes go-lucene#59 (backslash-escaped quote inside a phrase breaks the phrase early → query injection). This is the semantic-release driver.
  • chore(deps): minor group (supersedes chore(deps): bump the minor group across 1 directory with 13 updates #216) — azcore 1.22.0, azidentity 1.14.0, azcosmos 1.5.0, aws sns 1.41.1, otel contrib/runtime 0.69.0, otlp{metricgrpc,trace,tracegrpc} 1.44.0 (otel core co-bumped to 1.44 via MVS lockstep).
  • fix(telemetry): OTel 1.44 deprecationattribute.Value.Emit().String() in two test files. This is why chore(deps): bump the minor group across 1 directory with 13 updates #216's CI was red: magic has no local golangci config, so CI lints with default linters (staticcheck ON) and SA1019 failed the build. Behavior-preserving.
  • ci: SHA-pin remaining GitHub Actions + pin golangci-lint — ci.yml (webiny v1.4.2, checkout v7.0.0, setup-go v6.4.0, golangci-lint-action v9.3.0) and release.yml (go-semantic-release v1.24.1) pinned to commit SHAs; golangci-lint version: latestv2.12.2 to stop linter drift.

Verification

GOWORK=off build + test + golangci-lint run --no-config (staticcheck ON, CI-representative) all green — 0 lint issues.

Merge note

Squash-merge keeping the fix: subject so go-semantic-release cuts the tag (~v0.18.x). Supersedes #216 (close on merge) — the dependabot grouping config is already on main.

Summary by CodeRabbit

  • Chores

    • Updated build, lint, test, and release automation for more consistent and reproducible execution.
    • Refreshed supporting libraries and observability components to newer versions.
  • Tests

    • Updated telemetry validation to accurately represent attribute values.
    • Improved consistency when checking resource attributes, spans, and metrics.

Lutherwaves and others added 4 commits July 15, 2026 14:28
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@Lutherwaves, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 44 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3a68b38c-5281-4545-876e-46a41f0bcef4

📥 Commits

Reviewing files that changed from the base of the PR and between 818a140 and e5b73ca.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml
📝 Walkthrough

Walkthrough

The PR pins GitHub Actions to immutable commit SHAs, updates the golangci-lint version, refreshes Go dependencies, and changes telemetry tests to use OpenTelemetry attribute string conversion.

Changes

GitHub Actions pinning

Layer / File(s) Summary
Workflow action pinning
.github/workflows/ci.yml, .github/workflows/release.yml
CI and release workflows pin third-party actions to commit SHAs; the lint job uses golangci-lint v2.12.2.

Go dependency refresh

Layer / File(s) Summary
Go module version refresh
go.mod
Azure, AWS, OpenTelemetry, gRPC, grpc-gateway, and golang.org/x/* dependencies are updated.
Telemetry attribute conversion
observability/resource_test.go, storage/telemetry_test.go
Telemetry tests use String() instead of Emit() when constructing attribute maps.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: dependencies, github_actions

Suggested reviewers: deanefrati, dependabot[bot]

Poem

I pinned each action tight and true,
While fresh Go modules hopped into view.
Telemetry strings now softly gleam,
Tests follow the OpenTelemetry stream.
Squeak! CI runs on a steadier beam.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the main go-lucene upgrade and the related dependency and CI hardening changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/ci.yml:
- Around line 43-45: Add persist-credentials: false to both checkout steps in
.github/workflows/ci.yml at lines 43-45 and 77-79, covering the lint and test
jobs while preserving their existing fetch-depth settings.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9340683e-cfd3-4a74-876b-f794e5c32ef9

📥 Commits

Reviewing files that changed from the base of the PR and between df7d125 and 818a140.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (5)
  • .github/workflows/ci.yml
  • .github/workflows/release.yml
  • go.mod
  • observability/resource_test.go
  • storage/telemetry_test.go

Comment thread .github/workflows/ci.yml
@Lutherwaves Lutherwaves self-assigned this Jul 15, 2026

@Lutherwaves Lutherwaves left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allchanges are trivial and verified

@Lutherwaves
Lutherwaves merged commit da48dd4 into main Jul 15, 2026
4 checks passed
@Lutherwaves
Lutherwaves deleted the chore/consolidated-deps-vnext branch July 15, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lexPhrase does not honor backslash-escaped quote inside a phrase (breaks phrase early / query injection)

1 participant