Use tinkerbell/tinkerbell#208
Merged
jacobweinstock merged 3 commits intotinkerbell:mainfrom May 12, 2025
Merged
Conversation
This is the supported helm chart. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the deployment configuration to use the new tinkerbell chart repository and adjusts related network and environment settings.
- Updated the helm chart source from "tinkerbell/charts/stack" to "tinkerbell/charts/tinkerbell" and switched relevant chart value keys in setup.sh.
- Introduced a new variable (LOADBALANCER_IP_2) and updated IPs both in the Vagrantfile and the .env file.
- Changed the hostPath for hook artifacts in ubuntu-download.yaml.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| stack/vagrant/ubuntu-download.yaml | Changed hook-artifacts hostPath from "/opt/hook" to "/tmp". |
| stack/vagrant/setup.sh | Updated helm_install_tink_stack and run_helm functions with new chart source and extra parameter. |
| stack/vagrant/Vagrantfile | Adjusted environment variable values and shell provisioner arguments. |
| stack/vagrant/.env | Updated environment variables including helm chart version and loadbalancer IPs. |
Comments suppressed due to low confidence (2)
stack/vagrant/ubuntu-download.yaml:51
- Changing the hostPath for hook-artifacts from '/opt/hook' to '/tmp' may lead to unexpected data loss since /tmp is typically cleared on reboot. Verify that this change is intentional and that the artifacts do not require persistent storage.
path: /tmp
stack/vagrant/setup.sh:77
- Ensure that the updated chart source and new helm value keys (e.g., artifactsFileServer, deployment.init.sourceInterface, kubevip.interface) are fully compatible with the upstream tinkerbell chart configuration. Consider adding a comment or reference to the new chart documentation for clarity.
helm install tink-stack oci://ghcr.io/tinkerbell/charts/tinkerbell \
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates the stack playground to use the new helm chart from the github.com/tinkerbell/tinkerbell repo.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: