Fix #79 - Match official Dracula spec #80
Conversation
clach04
requested review from
FredHappyface and
JamyGolden
and removed request for
a team
|
I think this is ready for review. Quick compare: 
DraculaTinted is the previous colors in this repo. More screenshots coming. Minimal testing performed. My Text editor looks correct, I think the old color scheme looked good too, it just wasn't the official colors. It might be worth retaining with a different name? I've commented on colors that are not in Dracula spec, but they fill in gaps. It may make sense to switch the base00-07 colors around a little? Possibly in a later change? With this change the Putty generated output from https://github.com/tinted-theming/tinted-terminal is the same as the official Dracula Putty https://github.com/dracula/putty/ - with 2 minor exceptions which could be considered a matter of taste (and still within the official Dracula color scheme); Colour7 (ANSI Black Bright) and Colour20 (ANSI White). To be clear, the Official Dracula Putty is the faithfully correct one. Official color scheme for Putty screenshot in dracula/putty#12 |
|
Before and after Official: 
|
|
@JamyGolden - I need some advice. I do NOT see a way to reconcile the two remaining differences:
For both Terminals (base24, I'm ignore base16 terminals) and Text Editors. Should Base16 version of a scheme match the first 16 colors in Base24? I'm wondering if I make Dracula different, with the bas24e having different base02 and base06 colors. That way, selection color is preserved as per the Dracula spec for (base16) text editors, and the correct Dracula colors are used for terminals (for Base24). It seems like whatever is done it will be imperfect, what's the least worst thing to do? This may be another edge case that reinforces the need for your idea for more granularity on color names. Side note, I wish base10 and base11 had been used for ANSI white and black... |
… Black conflicts
JamyGolden
left a comment
JamyGolden
left a comment
There was a problem hiding this comment.
This shows a bug with base24. Base24 is meant to be a superset of base16, so these issues should be fixed in base24.
| base05: "#f8f8f2" | ||
| base06: "#f0f1f4" # NOT a Dracula color! | ||
| base05: "#f8f8f2" # Dracula AnsiWhite | ||
| base06: "#f0f1f4" # NOT a Dracula color!# FIXME base24 uses this as ANSI White |
There was a problem hiding this comment.
This is a base24 bug, base24 should have the same ANSI standard colours as base16
| base01: "#21222c" | ||
| base02: "#44475a" | ||
| base03: "#6272a4" | ||
| base02: "#44475a" # FIXME base24 uses this as ANSI Bright Black.. But text editors use this for Selection color - no clear solution here |
There was a problem hiding this comment.
This is a base24 bug, base24 should have the same ANSI standard colours as base16
| base05: "#f8f8f2" | ||
| base06: "#f0f1f4" # NOT a Dracula color! | ||
| base05: "#f8f8f2" # Dracula AnsiWhite | ||
| base06: "#f0f1f4" # NOT a Dracula color!# FIXME base24 uses this as ANSI White |
There was a problem hiding this comment.
This is a base24 bug, base24 should have the same ANSI standard colours as base16
2 participants
From https://spec.draculatheme.com/#sec-ANSI