Add merge method to Collectible for lazy concatenation of collections.#39
Add merge method to Collectible for lazy concatenation of collections.#39gustavofreze merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: adb234d174
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Adds a merge() API to Collectible/Collection to support lazy concatenation of two collections, with supporting internal operation, tests, and README documentation.
Changes:
- Introduces
Collectible::merge()and implements it inCollection. - Adds a new lazy write operation
Internal\Operations\Write\Merge. - Adds unit tests and README documentation for merging collections.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Internal/Operations/Write/CollectionMergeOperationTest.php | Adds coverage for merge() across empty/non-empty, chaining, duplicates, and a laziness-themed test. |
| src/Internal/Operations/Write/Merge.php | Implements a new lazy operation that concatenates two iterables. |
| src/Collection.php | Exposes merge() on Collection, wiring it through the lazy iterator pipeline. |
| src/Collectible.php | Adds the merge() method to the public Collectible interface with PHPDoc. |
| README.md | Documents the new merge() method under write operations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.