Skip to content

Add merge method to Collectible for lazy concatenation of collections.#39

Merged
gustavofreze merged 1 commit intomainfrom
feature/develop
Mar 3, 2026
Merged

Add merge method to Collectible for lazy concatenation of collections.#39
gustavofreze merged 1 commit intomainfrom
feature/develop

Conversation

@gustavofreze
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings March 3, 2026 04:54
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: adb234d174

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a merge() API to Collectible/Collection to support lazy concatenation of two collections, with supporting internal operation, tests, and README documentation.

Changes:

  • Introduces Collectible::merge() and implements it in Collection.
  • Adds a new lazy write operation Internal\Operations\Write\Merge.
  • Adds unit tests and README documentation for merging collections.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/Internal/Operations/Write/CollectionMergeOperationTest.php Adds coverage for merge() across empty/non-empty, chaining, duplicates, and a laziness-themed test.
src/Internal/Operations/Write/Merge.php Implements a new lazy operation that concatenates two iterables.
src/Collection.php Exposes merge() on Collection, wiring it through the lazy iterator pipeline.
src/Collectible.php Adds the merge() method to the public Collectible interface with PHPDoc.
README.md Documents the new merge() method under write operations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gustavofreze gustavofreze merged commit 99e7d40 into main Mar 3, 2026
10 checks passed
@gustavofreze gustavofreze deleted the feature/develop branch March 3, 2026 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants