testdata: attempt to deflake goroutines test

[jakebailey]

Fixes #4965

I got tired of hitting this flake locally and in CI. This change seems to make it pass, but it's a little unclear without more eyes whether or not I have defeated the purpose of this test somehow as I of course arrived here after this was committed...

[deadprogram]

I also find those failures very annoying. The tests are not so precise as to preclude these changes. Anyone have any objections for me to squash/merge?

[aykevl]

This kinda does defeat the original purpose of these tests. I wrote them a long time ago to show that TinyGo worked concurrently.

What about only running this test on systems without thread support? I don't think they're flaky there.

[deadprogram]

I think perhaps now that I have increased the runner sizes this should be less of a problem for the CI.

[jakebailey]

I hit this frequently when doing local testing, so I don't think increasing a builder size really fixes it...

[jakebailey]

What about only running this test on systems without thread support? I don't think they're flaky there.

Pushed that, at least

[deadprogram]

@jakebailey can you please rebase against the latest dev to rerun the tests? Thank you.

[aykevl]

Looks good to me. @deadprogram any thoughts?

[deadprogram]

Do we actually still need this? I think some recent changes such as #5487 have addressed the core problem.

[jakebailey]

If that worked, then we can close this and the two other issues.

[jakebailey]

Er, well, the part that works on #4965 is still relevant, but the timer stuff might not be?

[jakebailey]

Going to close this for now, I have not seen a race in a while; maybe the goroutine one is still around but I haven't seen it either.

Maybe both issues can be closed?

[jakebailey]

Just hit goroutines again, sadly:

1m 15s
1m 36s
Run go test -tags=llvm15 -short -skip=TestErrors
no Go files in /home/runner/work/tinygo/tinygo/tests/testing
--- FAIL: TestBuild (0.00s)
    --- FAIL: TestBuild/Host (0.00s)
        --- FAIL: TestBuild/Host/goroutines.go (2.90s)
            main_test.go:377: output did not match (expected 523 bytes, got 523 bytes):
            main_test.go:377: diff expected actual
                --- expected
                +++ actual
                @@ -10,8 +10,8 @@
                   wait end
                 end waiting
                 value produced after some time: 42
                -non-blocking goroutine
                 done with non-blocking goroutine
                +non-blocking goroutine
                 async interface method call
                 slept inside func pointer 8
                 slept inside closure, with value: 20 8
                

[deadprogram]

Thanks @jakebailey now merging.