Skip to content

added missing submissions_of_team method #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

seanmacavaney
Copy link

tira.rest_api_client.Client.get_run_execution_or_none calls submissions_of_team, which isn't defined. This PR adds this missing method.

@TheMrSheldon TheMrSheldon added bug Something isn't working python Pull requests that update Python code labels Jan 6, 2025
Copy link
Member

@TheMrSheldon TheMrSheldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for spotting and fixing this!
I have only added a minor comment. I understand that naming the return value and then returning it can improve readability but it may also be left out for more concise code. I leave it up to you and you can simply resolve the comment without changing anything as you see fit.

The PR is approved.

Comment on lines +233 to +234
filtered_submissions = submissions[submissions['team'] == team]
return filtered_submissions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
filtered_submissions = submissions[submissions['team'] == team]
return filtered_submissions
return submissions[submissions['team'] == team]

@TheMrSheldon
Copy link
Member

I am not too familiar with status checks on external PRs. Can you enable GitHub Actions in your fork to see if the status checks are run then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants