added missing submissions_of_team method #674
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMrSheldon
added
bug
TheMrSheldon
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Thank you very much for spotting and fixing this!
I have only added a minor comment. I understand that naming the return value and then returning it can improve readability but it may also be left out for more concise code. I leave it up to you and you can simply resolve the comment without changing anything as you see fit.
The PR is approved.
Comment on lines
+233
to
+234
| filtered_submissions = submissions[submissions['team'] == team] | ||
| return filtered_submissions |
There was a problem hiding this comment.
Suggested change
| filtered_submissions = submissions[submissions['team'] == team] | |
| return filtered_submissions | |
| return submissions[submissions['team'] == team] |
|
I am not too familiar with status checks on external PRs. Can you enable GitHub Actions in your fork to see if the status checks are run then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tira.rest_api_client.Client.get_run_execution_or_nonecallssubmissions_of_team, which isn't defined. This PR adds this missing method.