Adding testvectors. Adding clarifications in the body.#24
Open
hannestschofenig wants to merge 2 commits into
Open
Adding testvectors. Adding clarifications in the body.#24hannestschofenig wants to merge 2 commits into
hannestschofenig wants to merge 2 commits into
Conversation
hannestschofenig
commented
Jun 1, 2026
Comment on lines
+449
to
457
| The following entry is added to the "JSON Web Signature and Encryption Header Parameters" registry: | ||
|
|
||
| - Header Parameter Name: ek | ||
| - Header Parameter Description: KEM ciphertext | ||
| - Header Parameter Usage Location(s): JWE | ||
| - Change Controller: IESG | ||
| - Specification Document(s): [[TBD: This RFC]] | ||
|
|
||
| The following entries are added to the "JSON Web Signature and Encryption Algorithms" registry: |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| The following entry is added to the "JSON Web Signature and Encryption Header Parameters" registry: | |
| - Header Parameter Name: ek | |
| - Header Parameter Description: KEM ciphertext | |
| - Header Parameter Usage Location(s): JWE | |
| - Change Controller: IESG | |
| - Specification Document(s): [[TBD: This RFC]] | |
| The following entries are added to the "JSON Web Signature and Encryption Algorithms" registry: |
Collaborator
Author
There was a problem hiding this comment.
Removed it because it will be registered via JOSE HPKE first. The description of the JOSE HPKE-defined parameter does not quite fit but this is something we will have to look into.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I am making three changes:
Adding Test Vectors for JOSE based on the implementation at Add experimental JOSE PQC KEM support panva/jose#870
Clarifications regarding the private key encoding
Clarifications regarding KDF usage