Skip to content
This repository was archived by the owner on Jan 29, 2026. It is now read-only.

[react-contexts] trackScreen에 nol_device_id를 기록하도록 수정합니다.#3617

Merged
dongoc merged 4 commits intoepic/KLZT-856_nol_userfrom
KLZT-901_nol-track-screen
Apr 4, 2025
Merged

[react-contexts] trackScreen에 nol_device_id를 기록하도록 수정합니다.#3617
dongoc merged 4 commits intoepic/KLZT-856_nol_userfrom
KLZT-901_nol-track-screen

Conversation

@dongoc
Copy link
Copy Markdown
Contributor

@dongoc dongoc commented Mar 26, 2025

PR 설명

[react-contexts] trackScreen에 nol_device_id를 기록하도록 수정합니다. (관련 스레드)

변경 내역

  • 앱과 웹의 metadata가 다르므로 app, web용 인자를 분리했습니다.

@dongoc dongoc self-assigned this Mar 26, 2025
@dongoc dongoc added this to the 13.nol milestone Mar 26, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

Project coverage is 10.07%. Comparing base (4f021fe) to head (fdb68ed).
Report is 18 commits behind head on epic/KLZT-856_nol_user.

Files with missing lines Patch % Lines
.../event-tracking-context/event-tracking-context.tsx 0.00% 6 Missing ⚠️
...ent-tracking-context/utils/get-triple-device-id.ts 71.42% 2 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           epic/KLZT-856_nol_user    #3617      +/-   ##
==========================================================
+ Coverage                   10.06%   10.07%   +0.01%     
==========================================================
  Files                         740      741       +1     
  Lines                       29060    29100      +40     
  Branches                     7898     7912      +14     
==========================================================
+ Hits                         2924     2931       +7     
- Misses                      26116    26149      +33     
  Partials                       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dongoc
Copy link
Copy Markdown
Contributor Author

dongoc commented Mar 26, 2025

release-canary

@github-actions
Copy link
Copy Markdown

v13.44.1-pr-3617.20 has been published!

@dongoc
Copy link
Copy Markdown
Contributor Author

dongoc commented Mar 31, 2025

release-canary

@github-actions
Copy link
Copy Markdown

v13.44.1-pr-3617.22 has been published!

@dongoc dongoc changed the title trackScreen에 nol_device_id 기록 [react-contexts] trackScreen에 nol_device_id를 기록하도록 수정합니다. Mar 31, 2025
@dongoc dongoc marked this pull request as ready for review April 2, 2025 06:24
@dongoc dongoc requested a review from a team as a code owner April 2, 2025 06:24
@dongoc dongoc requested review from YWTechIT, drakang4, guswl98 and jhyj0521 and removed request for a team April 2, 2025 06:24
@guswl98 guswl98 force-pushed the epic/KLZT-856_nol_user branch from 69d533b to 4f021fe Compare April 3, 2025 01:46
@dongoc dongoc force-pushed the KLZT-901_nol-track-screen branch from 2012218 to fdb68ed Compare April 3, 2025 01:49
Copy link
Copy Markdown
Contributor

@guswl98 guswl98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dongoc
Copy link
Copy Markdown
Contributor Author

dongoc commented Apr 4, 2025

🙇‍♂️

@dongoc dongoc merged commit c957d85 into epic/KLZT-856_nol_user Apr 4, 2025
11 checks passed
@dongoc dongoc deleted the KLZT-901_nol-track-screen branch April 4, 2025 07:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants