-
Notifications
You must be signed in to change notification settings - Fork 11
보안 취약점 대응 storybook 버전 업데이트 #3775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v13
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v13 #3775 +/- ##
=======================================
Coverage 10.08% 10.08%
=======================================
Files 743 743
Lines 29160 29160
Branches 7912 7912
=======================================
Hits 2940 2940
Misses 26198 26198
Partials 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| builder: { | ||
| useSWC: true, | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Storybook 7.6.21 이상부터는 Next.js 14 미만 버전과 SWC 옵션을 함께 사용할 수 없다고 합니다....
v13이 지원하는 Next.js 버전은 13.4.13이기 때문에 SWC 옵션을 제거합니다.
| babel: async (config) => { | ||
| return { | ||
| ...config, | ||
| presets: [ | ||
| [ | ||
| 'next/babel', | ||
| { | ||
| 'preset-react': { | ||
| runtime: 'automatic', | ||
| throwIfNamespace: false, | ||
| }, | ||
| }, | ||
| ], | ||
| ], | ||
| } | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
swc를 사용할 수 없게 되면서 기본 babel을 사용하게 되는데, Babel의 기본 설정 throwIfNamespace: true가 ses:tags 같은 namespace 태그를 허용하지 않아 스토리북 빌드에 실패합니다.
preset-react 옵션으로 throwIfNamespace를 false로 설정합니다.
PR 설명
storybook의 보안 취약점 대응 버전 업데이트를 진행합니다.
변경 내역