Fix session close handling in command-line client #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renemarc
commented
Mar 26, 2020
Comment on lines
-4
to
-5
| import asyncio | ||
| import json |
Contributor
Author
There was a problem hiding this comment.
opportunistic removal of unused packages
renemarc
commented
Mar 26, 2020
Comment on lines
+39
to
+40
| def __init__(self, username, password, timeout=REQUESTS_TIMEOUT, | ||
| session=None): |
Contributor
Author
There was a problem hiding this comment.
opportunistic PEP-8 line-wrap
renemarc
commented
Mar 26, 2020
| return self._data | ||
|
|
||
| def close_session(self): | ||
| async def close_session(self): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the master branch module is working well, using the command-line client still issues the warning:
This PR aims to fix this by removing session-closing duties from the client and handing them over to the EboxClient class.
BREAKING CHANGE: method
close_session()must now be awaited.