Clean code#39
Open
titus-ong wants to merge 52 commits into
Open
Conversation
…nto abstract class
…ccess them easily
… overriding abstract methods)
This was referenced Aug 31, 2020
Owner
Author
|
Currently implemented #9 - available in the utils folder. |
…requires ignoring case)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revamping entire architecture of chordparser. Editors are removed (did way too much in one class) and are changed for music classes to use composition on their editors. Some classes have been split into multiple smaller classes for clearer definition of responsibility. Enums have been used for notation. Methods, variables etc. are now defined with more meaningful names for easier reading of code.
See the planned architecture at https://app.creately.com/diagram/mgDA6MoHqV7/edit. May not be entirely up-to-date but the structure is similar.