Skip to content

fix: add a peak LED on signal display, avoid overflow #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ylmrx wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add a peak LED on signal display, avoid overflow #899

ylmrx wants to merge 2 commits into from
+64 −49

Conversation

@ylmrx
Copy link
Contributor

@ylmrx ylmrx commented Dec 21, 2025 •
edited
Loading

  • ensure bass api level is >0 (signed integer overflowing on very loud music and full-scale white noise)
  • replace slider with a custom meter:
    • use better padding (meter went beyond panel limits on overdriven signals)
    • add a peak LED
    • add some ballistic to smooth out level decay
  • fix few labels

ylmrx added 2 commits December 25, 2025 17:29
@ylmrx
fix: add a peak LED on signal display, avoid overflow
ed68803
@ylmrx
enable a better-looking input level meter
45117e4 
- fix some labels in the panel
- add some smoothing ballistic on the level decay
- display a gradient with opacity effect instead of slider
- fix scaling on level-width
@ylmrx ylmrx force-pushed the fix/make_sound_props_prettier branch from 9bbfb9d to 45117e4 Compare December 25, 2025 18:59
@ylmrx ylmrx marked this pull request as ready for review December 25, 2025 19:00
@ylmrx
Copy link
Contributor Author

ylmrx commented Dec 25, 2025 •
edited
Loading

20251225-1838-29.1556140.mp4

(music snippet , Jomaa - Free Bird (Amelie Lens 016 mix-tape))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ylmrx