feat: Display the time timeClip hovers in the same unit as the timeline#903
Draft
ylmrx wants to merge 2 commits intotixl3d:mainfrom
Draft
feat: Display the time timeClip hovers in the same unit as the timeline#903ylmrx wants to merge 2 commits intotixl3d:mainfrom
ylmrx wants to merge 2 commits intotixl3d:mainfrom
Conversation
pixtur
requested changes
Jan 2, 2026
Collaborator
pixtur
left a comment
pixtur
left a comment
There was a problem hiding this comment.
I think we should discuss this. I first need to understand what you're trying to achieve with these lines.
Comment on lines
+404
to
+407
| private static Playback _timeRangeStart = new(); | ||
| private static Playback _timeRangeEnd = new(); | ||
| private static Playback _sourceRangeStart = new(); | ||
| private static Playback _sourceRangeEnd = new(); |
Collaborator
There was a problem hiding this comment.
I'm not really sure what these lines mean.
In the context of TiXL Core/Animation/Playback.cs is a pretty complex objects controlling the advance of time. Why do you need multiple instances here?
If it's called "Range" shouldn't this be TimeRange or TimeClips ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Edit stretch" menu will be difficult to migrate to this and keep coherent, so im not sure with this one...