Fix Integer Overflow Vulnerability in Buffer Write Method #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request addresses a security vulnerability in the write() method by implementing proper bounds checking to prevent integer overflow. Issue The original implementation used a pattern vulnerable to integer overflow by checking off + len > b.length, which could wrap around to a small value when both offset and length are large, bypassing the bounds check. This vulnerability was also identified in ReadyTalk/avian@0871979 and fixed subsequently. References: 1. ReadyTalk/avian@0871979 2. https://nvd.nist.gov/vuln/detail/CVE-2019-1010296 Signed-off-by: Lim Sim Yee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses a security vulnerability in the write() method by implementing proper bounds checking to prevent integer overflow.
Issue
The original implementation used a pattern vulnerable to integer overflow by checking off + len > b.length, which could wrap around to a small value when both offset and length are large, bypassing the bounds check.
This vulnerability was also identified in ReadyTalk/avian@0871979 and fixed subsequently.
References: