Interpret 'nodeProcessCommandLine' as a relative path if it starts with '.'#356
Open
MrHacky wants to merge 1 commit intotjanczuk:masterfrom
Open
Interpret 'nodeProcessCommandLine' as a relative path if it starts with '.'#356MrHacky wants to merge 1 commit intotjanczuk:masterfrom
MrHacky wants to merge 1 commit intotjanczuk:masterfrom
Conversation
|
Is there a reason this hasn't been merged yet? A completely self-contained app can be tremendously beneficial during deployment |
|
I like the idea of containing node.exe in the app itself |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch i'm currently using to simplify deployment a little. I can now deploy a complete app (with private node.exe and web.config) by unzipping a zip file on our web server.
Is there interest to merge this (or something like it) into iisnode?
(a similar solution was proposed for #175, but nothing came of that)