Skip to content

Add watermark to first page in print jobs (bottom right corner)#1919

Closed
blues-hue wants to merge 4 commits into
tjcsl:devfrom
blues-hue:watermark
Closed

Add watermark to first page in print jobs (bottom right corner)#1919
blues-hue wants to merge 4 commits into
tjcsl:devfrom
blues-hue:watermark

Conversation

@blues-hue

@blues-hue blues-hue commented May 24, 2026

Copy link
Copy Markdown

Proposed changes

  • Adds a watermark to the first page on the bottom right corner on print jobs (Ion user and job id)
  • Some risks are that the system is only created so far, so the user can't really see where the watermark will go, but the location is hardcoded based on page width
  • Deleted the title page creation

Brief description of rationale

@blues-hue blues-hue requested a review from a team as a code owner May 24, 2026 22:02
@coveralls

coveralls commented May 25, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 78.515% (-0.1%) from 78.618% — blues-hue:watermark into tjcsl:dev

@aarushtools

aarushtools commented Jun 16, 2026

Copy link
Copy Markdown
Member

No difference from existing impl. #1883
You can reopen it if you have a different solution

@blues-hue

blues-hue commented Jun 17, 2026

Copy link
Copy Markdown
Author

No difference from existing impl. #1883 You can reopen it if you have a different solution

@aarushtools sorry, what would you say is a different implementation? Would you consider shrinking the page to about 98% of its original size then adding the watermark at the bottom as a different implementation? Or should I have an entirely different solution (i.e. i thought of adding a qr code linking to a page with their details)

@crushedflea8060

Copy link
Copy Markdown

@blues-hue just my input, but I wouldn't recommend doing a QR code since we won't technically be allowed to use phones next year. Also, what's your rationale for making an alternative PR? There's another PR that closes this same issue, as Aarush said.

@blues-hue

blues-hue commented Jun 20, 2026

Copy link
Copy Markdown
Author

@blues-hue just my input, but I wouldn't recommend doing a QR code since we won't technically be allowed to use phones next year. Also, what's your rationale for making an alternative PR? There's another PR that closes this same issue, as Aarush said.

@crushedflea8060 You're right about the QR code, I did not think about that. My rationale for an alternative PR is only making the watermark on the first page, as having a watermark on every page could be kind of annoying in some print jobs. Also, I originally made this alternative PR for the Understudy Program (Aarush said I could do an alternative implementation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minimize paper used across jobs

4 participants