Track credits usage #119
Merged
Track credits usage #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web/accounts/models.py
Outdated
| @@ -100,6 +120,19 @@ def record_consumed_credits(self, credits): | |||
| f"Error recording consumed credits for {self.email}", "fatal" | |||
| ) | |||
|
|
|||
| def record_credit_usage( | |||
There was a problem hiding this comment.
Hey - this is easy to make async, and will make things cleaner when we use in the view. Can we change it?
web/api/views.py
Outdated
| @@ -1465,6 +1503,11 @@ async def consume_credits(request, available_credits, consumed_credits): | |||
| f"Set available credits to 0 and recorded {consumed_credits - available_credits} consumed credits" | |||
| ) | |||
|
|
|||
| # track credit usage | |||
| await sync_to_async(request.auth.record_credit_usage)( | |||
There was a problem hiding this comment.
This can be simplified and cleaner if we make record_credit_usage async
Jonathan-Adly
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses this issue
Example of frontend display
Type of change
(e.g., refactoring, docs, tests, admin site changes)
Release Impact
Checklist
Breaking Changes
Migration Guide
Additional Notes