Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search image credits #131

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Search image credits #131

merged 1 commit into from
Jan 7, 2025

Conversation

Abdullah13521
Copy link
Contributor

@Abdullah13521 Abdullah13521 commented Jan 7, 2025

Description

Make search-image consume 1 credit. Addresses this issue.

Type of change

  • 🚨 Breaking change - causes existing functionality to break (triggers MAJOR version bump)
  • ✨ New feature - adds functionality in a non-breaking way (triggers MINOR version bump)
  • 🐛 Bug fix - fixes an issue without changing functionality (triggers PATCH version bump)
  • 🏠 Internal - changes that don't affect external functionality (no version bump)
    (e.g., refactoring, docs, tests, admin site changes)

Release Impact

  • Current version:
  • Next version will be:

Checklist

  • My code follows the style guidelines
  • My code is tested with 99%+ coverage
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have updated the documentation to reflect my changes
  • I have added/updated tests to cover my changes

Breaking Changes

Migration Guide

Additional Notes

@Abdullah13521 Abdullah13521 changed the base branch from main to cloud January 7, 2025 14:33
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
web/api/views.py 75.00% 1 Missing ⚠️
Flag Coverage Δ
unittests 99.40% <75.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
web/api/views.py 98.07% <75.00%> (ø)

@Jonathan-Adly Jonathan-Adly merged commit b247252 into cloud Jan 7, 2025
2 checks passed
@Jonathan-Adly Jonathan-Adly deleted the search-image-credits branch January 7, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants