Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default collection -> default_collection #80

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

Jonathan-Adly
Copy link
Contributor

@Jonathan-Adly Jonathan-Adly commented Nov 8, 2024

Description

We are changing the default collection from: default collection -> default_collection. Closes #73

Type of change

  • 🏠 Internal - changes that don't affect external functionality (no version bump)
    (e.g., refactoring, docs, tests, admin site changes)

Checklist

  • My code follows the style guidelines
  • My code is tested with 99%+ coverage
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have updated the documentation to reflect my changes
  • I have added/updated tests to cover my changes

Breaking Changes

  • Need to update doc
  • Need to update SDK (PR opened)

Migration Guide

N/A

Additional Notes

@Jonathan-Adly Jonathan-Adly added the patch PATCH (x.x.X): Bug fixes and minor changes label Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 99.69% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
web/api/tests/tests.py 100.00% <100.00%> (ø)
web/api/views.py 100.00% <ø> (ø)

@Jonathan-Adly Jonathan-Adly merged commit 006a738 into main Nov 8, 2024
2 checks passed
@Jonathan-Adly Jonathan-Adly deleted the main-default-collection branch November 8, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch PATCH (x.x.X): Bug fixes and minor changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change "default collection" to "default_collection"
1 participant