Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved max sim #95

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Improved max sim #95

merged 4 commits into from
Nov 19, 2024

Conversation

Jonathan-Adly
Copy link
Contributor

Description

Instead of using max cosine similarity - we will use Dot product. I ran benchmarks and results are roughly the same, but dot product is slightly faster.

Type of change

  • 🏠 Internal - changes that don't affect external functionality (no version bump)
    (e.g., refactoring, docs, tests, admin site changes)

Release Impact

Minor

Checklist

  • My code follows the style guidelines
  • My code is tested with 99%+ coverage
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have updated the documentation to reflect my changes
  • I have added/updated tests to cover my changes

Breaking Changes

The normalized score might act a little differently now

@Jonathan-Adly Jonathan-Adly added the minor MINOR (x.X.x): New features, backward compatible label Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 99.72% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
web/api/models.py 98.49% <100.00%> (-0.01%) ⬇️
web/api/views.py 100.00% <100.00%> (ø)

🚨 Try these New Features:

@Jonathan-Adly Jonathan-Adly merged commit 881d399 into main Nov 19, 2024
2 checks passed
@Jonathan-Adly Jonathan-Adly deleted the improved-max-sim branch November 19, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor MINOR (x.X.x): New features, backward compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant