Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webhook frontend #98

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Add webhook frontend #98

merged 3 commits into from
Nov 22, 2024

Conversation

Abdullah13521
Copy link
Contributor

@Abdullah13521 Abdullah13521 commented Nov 21, 2024

Description

Addresses this issue.

Type of change

  • 🚨 Breaking change - causes existing functionality to break (triggers MAJOR version bump)
  • ✨ New feature - adds functionality in a non-breaking way (triggers MINOR version bump)
  • 🐛 Bug fix - fixes an issue without changing functionality (triggers PATCH version bump)
  • 🏠 Internal - changes that don't affect external functionality (no version bump)
    (e.g., refactoring, docs, tests, admin site changes)

Release Impact

  • Current version:
  • Next version will be:

Checklist

  • My code follows the style guidelines
  • My code is tested with 99%+ coverage
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have updated the documentation to reflect my changes
  • I have added/updated tests to cover my changes

Breaking Changes

Migration Guide

Additional Notes

@Abdullah13521 Abdullah13521 changed the base branch from main to cloud November 21, 2024 17:08
</form>

{% if request.user.svix_endpoint_secret %}
<h2 data-scrollspy-target id="webhook-secret">Your Webhook Secret</h2>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this so there's way for cloud users to know their webhook secret, since they can't access it otherwise

<h2 data-scrollspy-target id="webhook">Webhook</h2>
<p>
Set up a webhook to receive notifications on for async document upsertion. If not set up, you will receive an email if the document upsertion fails.
For more details, you can check Colivara's docs at https://docs.colivara.com/.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be changed to link to the correct docs when they are available

@Abdullah13521 Abdullah13521 added the cloud-only changes only to the cloud branch label Nov 21, 2024
@Jonathan-Adly Jonathan-Adly merged commit 0b30279 into cloud Nov 22, 2024
1 check passed
@Jonathan-Adly Jonathan-Adly deleted the webhook-frontend branch November 26, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloud-only changes only to the cloud branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants