feat: decouple fulfillment email side-effects via domain events#34
Open
tkahng wants to merge 3 commits into
Open
feat: decouple fulfillment email side-effects via domain events#34tkahng wants to merge 3 commits into
tkahng wants to merge 3 commits into
Conversation
FulfillmentShippedEvent and FulfillmentDeliveredEvent records replace direct EmailService calls in FulfillmentService. FulfillmentEmailEventListener handles delivery after transaction commit (@TransactionalEventListener + @async), matching the existing OrderEmailEventListener pattern.
…alls FulfillmentServiceIT and NotificationPreferenceGateIT were verifying emailService mock calls that now fire asynchronously after transaction commit. Switched to asserting on FulfillmentShippedEvent / FulfillmentDeliveredEvent via @RecordApplicationEvents, matching the existing pattern used for OrderConfirmedEvent / OrderCancelledEvent.
…lfillmentServiceIT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FulfillmentShippedEventandFulfillmentDeliveredEventdomain event recordsFulfillmentEmailEventListener— handles both events with@TransactionalEventListener(AFTER_COMMIT)+@Async("emailExecutor"), matching the existingOrderEmailEventListenerpatternFulfillmentServiceto publish events instead of callingEmailServicedirectly, removing theEmailServicedependency from that service entirelyMotivation
FulfillmentService.update()was callingemailService.sendShippingNotification()andemailService.sendOrderDelivered()inline inside a@Transactionalmethod. This meant:FulfillmentServicewas tightly coupled toEmailServicePublishing events after commit (same pattern already used for
OrderConfirmedEvent/OrderCancelledEvent) fixes all three issues.Changes
fulfillment/event/FulfillmentShippedEvent.javafulfillment/event/FulfillmentDeliveredEvent.javafulfillment/event/FulfillmentEmailEventListener.javafulfillment/service/FulfillmentService.javaEmailService; injectApplicationEventPublisher; replace private email methods with event publishingfulfillment/event/FulfillmentEmailEventListenerTest.javaTest plan
./mvnw test -Dtest="FulfillmentEmailEventListenerTest"— 4 tests pass./mvnw test— full suite still greenFulfillmentServiceno longer importsEmailService:grep -r "EmailService" src/main/java/io/k2dv/garden/fulfillment/