Skip to content

Update AWS nitro crates and deps for qos_enclave - #607

Open
cr-tk wants to merge 1 commit into
mainfrom
christian/aws-bump
Open

Update AWS nitro crates and deps for qos_enclave#607
cr-tk wants to merge 1 commit into
mainfrom
christian/aws-bump

Conversation

@cr-tk

@cr-tk cr-tk commented Jan 15, 2026

Copy link
Copy Markdown
Collaborator

Summary & Motivation (Problem vs. Solution)

AWS has recently announced GHSA-g59m-gf8j-gjf5 which classifies a recent improvement in their API across in many of their Rust SDK crates as a security patch. This is a motivation to adopt newer versions of the AWS SDK crates that we use for qos_enclave.

At the time of writing, we can not switch aws-sdk-kms to a new enough version since other AWS crates such as aws-nitro-enclaves-image-format explicitly require use of older versions, see aws/aws-nitro-enclaves-image-format#49.

Additional restrictions on aws-config version ranges, combined with cargo restrictions on allowed parallel usage of different major versions of the same crate (such as aws-types 1.1.9 and 1.3.11) unfortunately make it difficult for us to adopt the newer versions.
For example, our tests build with aws-types 0.101.0 but then fail with

the trait aws_config::meta::region::ProvideRegion is not implemented for aws_types::region::Region

during runtime, and newer 1.0.x or 1.1.x versions aren't allowed due to the previously mentioned cargo rules. This holds back what this PR can currently do.

The aws-nitro-enclaves-image-format development has finally dropped atty as a transitive dependency, allowing us to get rid of it and the related security warnings (unmaintained crate) as described in aws/aws-nitro-enclaves-image-format#44 . Since there's no official release for that yet, we have to use the Cargo patch mechanism as a workaround to enforce this. https://github.com/advisories/GHSA-g98v-hv3f-hcf is also related, but not relevant for us.

How I Tested These Changes

CI

@cr-tk cr-tk changed the title Patch AWS crates for qos_enclave Partially patch AWS crates for qos_enclave Jan 15, 2026
@cr-tk
cr-tk force-pushed the christian/aws-bump branch from 4bdd6d1 to 7f175a7 Compare January 15, 2026 21:23
@cr-tk
cr-tk force-pushed the christian/aws-bump branch from 7f175a7 to d1571c2 Compare February 4, 2026 18:02
@cr-tk

cr-tk commented May 12, 2026

Copy link
Copy Markdown
Collaborator Author

The situation unfortunately hasn't improved since the AWS crates and repositories have not been updated to be compatible with patched versions.

@cr-tk
cr-tk force-pushed the christian/aws-bump branch 2 times, most recently from 6fbecce to da91231 Compare May 20, 2026 17:13
@cr-tk
cr-tk force-pushed the christian/aws-bump branch from da91231 to 9df91ad Compare July 24, 2026 11:23
@cr-tk

cr-tk commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator Author

Updated the nitro-cli pin from 1.4.4 to 1.4.5. Unfortunately, this doesn't change the overall situation regarding the other AWS crates.

Given the partial improvement for some transitive dependencies, I think we should go forward with merging this now, to get the partial benefits that are reachable now.

Note that the new nitro-cli version required bumping the MSRV of qos_enclave from 1.88 to 1.92, but this is below our current 1.94 tooling level and should be okay.

@cr-tk
cr-tk marked this pull request as ready for review July 24, 2026 11:26
@cr-tk
cr-tk requested a review from a team as a code owner July 24, 2026 11:26
@cr-tk
cr-tk force-pushed the christian/aws-bump branch from 9df91ad to 958111c Compare July 24, 2026 11:46
@cr-tk cr-tk changed the title Partially patch AWS crates for qos_enclave Update AWS nitro crates and deps for qos_enclave Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant