qos_core: add attestation/manifest verification helpers - #765
Draft
emostov wants to merge 2 commits into
Draft
Conversation
emostov
added a commit
to tkhq/rust-sdk
that referenced
this pull request
Jul 16, 2026
The fake manifest builder and trust chain verifier were ported verbatim
to qos_core::protocol::services::boot::{fake, verify} in qos PR #765
(tkhq/qos#765). tvc-axum tests already consume
them from qos_core, so the crate has no remaining users.
emostov
commented
Jul 16, 2026
emostov
commented
Jul 16, 2026
emostov
changed the title
emostov
force-pushed
the
zeke/manifest-fake-and-verify-helpers
branch
5 times, most recently
from
July 23, 2026 19:06
4bc275c to
a3dfc25
Compare
Add a mock-gated boot::fake module with FakeManifestBuilder and helpers for generating fake v2 manifests, envelopes, and quorum members in tests, including real threshold signatures over the manifest hash via build_envelope_approved_by. Ported from rust-sdk's tvc-utils crate. qos_core: add attestation and manifest verification helpers Add boot::verify with verify_attestation_and_manifest, which checks a manifest envelope against caller-supplied VerificationExpectations, binds it to an NSM attestation document (user data and PCR0-3), verifies the document up to a root CA, checks manifest-set threshold approvals, and returns the enclave's ephemeral public key. Ported from rust-sdk's tvc-utils crate. qos_core: add manifest/share set expectations to verify helpers Allow callers of verify_attestation_and_manifest to verify the manifest set and share set, either by exact match (threshold and members) or by expecting individual members to be in a set. qos_core: verify boot-phase manifest commitment PCR in verify helpers verify_attestation_and_manifest now takes a ManifestCommitmentKind and checks that PCR16 (setup) or PCR17 (live) commits to the manifest hash and the enclave's ephemeral public key, matching the commitments QOS extends and locks at boot. qos_core: drop the fake manifest builder Remove the boot::fake module and its re-exports; the verify tests now construct manifests with minimal test-local helpers. qos_core: separate verify helper tests
emostov
force-pushed
the
zeke/manifest-fake-and-verify-helpers
branch
from
July 23, 2026 19:28
a3dfc25 to
4542a60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
qos_core::verify::{verify_attestation_and_manifest, verify_attestation_and_manifest_envelope}.