Skip to content

use envsubst to insert the NPM_TOKEN into .npmrc#777

Merged
turnekybc merged 4 commits intomainfrom
bc-update-publish-workflow
Jul 31, 2025
Merged

use envsubst to insert the NPM_TOKEN into .npmrc#777
turnekybc merged 4 commits intomainfrom
bc-update-publish-workflow

Conversation

@turnekybc
Copy link
Contributor

@turnekybc turnekybc commented Jul 30, 2025

Summary & Motivation

  • check for the existence of .npmrc.ci and use envsubst to insert the NPM_TOKEN into the template and update .npmrc

How I Tested These Changes

  • will test via release

Did you add a changeset?

  • added patch changeset to test publishing of @turnkey/viem

@vercel
Copy link

vercel bot commented Jul 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sdk-react-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2025 7:17pm

@turnekybc turnekybc requested a review from Copilot July 30, 2025 21:19

This comment was marked as outdated.

This comment was marked as outdated.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 30, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 14cb3bd:

Sandbox Source
@turnkey/example-react-components Configuration

@turnekybc turnekybc requested a review from Copilot July 30, 2025 21:37
@turnekybc turnekybc changed the title use envsubst to insert the NPM_TOKEN into .npmrc use sed to insert the NPM_TOKEN into .npmrc Jul 30, 2025

This comment was marked as outdated.

@turnekybc turnekybc requested a review from Copilot July 30, 2025 21:38

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@turnekybc turnekybc changed the title use sed to insert the NPM_TOKEN into .npmrc use envsubst to insert the NPM_TOKEN into .npmrc Jul 31, 2025
@turnekybc turnekybc requested a review from Copilot July 31, 2025 16:10

This comment was marked as outdated.

@turnekybc turnekybc requested a review from Copilot July 31, 2025 16:14

This comment was marked as outdated.

This comment was marked as outdated.

@turnekybc turnekybc requested a review from Copilot July 31, 2025 16:19

This comment was marked as outdated.

@turnekybc turnekybc force-pushed the bc-update-publish-workflow branch from d273129 to cbb0ba0 Compare July 31, 2025 16:27
@turnekybc turnekybc requested a review from Copilot July 31, 2025 16:27

This comment was marked as outdated.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the NPM authentication setup in the CI workflow by using envsubst to securely template the NPM token into .npmrc files, replacing the previous approach of directly appending the token.

  • Uses envsubst to template NPM_TOKEN into .npmrc from .npmrc.ci template when available
  • Masks the NPM token in GitHub Actions logs for improved security
  • Adds a test changeset for the @turnkey/viem package to validate the publishing process

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/version-and-publish.yml Updates NPM configuration setup to use envsubst templating and adds token masking
.changeset/itchy-chicken-join.md Adds test changeset for @turnkey/viem package

@turnekybc turnekybc merged commit dfda735 into main Jul 31, 2025
9 checks passed
@turnekybc turnekybc deleted the bc-update-publish-workflow branch July 31, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants