feat: enabled reporter reuse (#131) #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tronje Krop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables the reporter to be reused in multiple test scenarios, i.e. on
*testing.T,*testing.B,*testing.TB, andtest.Test, which allows to implement common setup functions for tests and benchmarks. As external sign, it also actively implementstest.Testto embedtest.Reporter.To allow for testing of the additional edge cases, the
test.Contextnow supports to change the expectation during the test setup. To avoid duplication of setup, I removed in a breaking change the expectation from thetest.New(...)function - that usually should not be used by consumers - may be I should not have exported it in the first place.