CI: only run tests for OCaml 5 or higher #224
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Helwer <[email protected]>
ahelwer
force-pushed
the
ci-only-use-ocaml-5-1
branch
from
4ec2359 to
e82ce82
Compare
Collaborator
|
I don't know. Debian stable (bookwork) still ships with 4.13. That was the argument to support OCaml version 4 last time we discussed this. If we support it, we should run the tests there as well. |
Collaborator
Author
|
That makes sense. Should we make a 4.13 ocaml release as well then or does it not matter? |
Collaborator
|
I guess the OCaml version doesn't matter when the binary has already been compiled. Then there is no need for a separate release. The support for older versions is probably important for those who build it from source. |
ahelwer
added
the
ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kape1395 thoughts?