-
Notifications
You must be signed in to change notification settings - Fork 44
Add Unicode Operator completions #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for the PR! To get it across the finish line, the feature needs to be disabled by default, since not all users want it and not all tools support Unicode characters. |
|
@lemmy Good note, that's been added now. I'm still not sure of how to get rid of the leading |
Signed-off-by: miguelraz <[email protected]>
Signed-off-by: miguelraz <[email protected]>
|
Force pushed to get proper signoffs. |
|
@miguelraz Thanks for the PR! Could you add tests for operator completions? - especially the case where Unicode autocomplete is on but the operator has no mapping? |
…ompletions The formatting of the consts TLA_UNICODE_OPERATORS and TLA_OPERATORS was done with the assistance of Claude Sonnet 4. Signed-off-by: miguelraz <[email protected]>
(You've probably thought of this but anyway) from looking at the code it looks like you define the translation without the preceding backslash, like The full list of supported Unicode symbols can be found here. Given their number I suggest writing a quick script in Python (or similar) ingesting the CSV and spitting out the desired code. Believe me, I've manually written all these out quite a few times and scripting is just so much nicer. In the TLAUC project it was also found to be useful to skip translating specific groups of symbols, in particular the |
|
Signed-off-by: miguelraz <[email protected]>
|
@miguelraz would it help to have additional usability testing by running this build on my machine, or are the issues basically all known at this point? |
|
If there are usability issues, I can't come up with them at the moment. |
This is my first typescript PR ever, so please bear with me if I screwed something up.
The PR has a small bug in it which I couldn't figure out - typing
\in<TAB>autocompletes to\∈and not∈.This is already a usability win for me, so I'm hoping someone else can help get this PR across the finish line.