-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
alr: add page and Spanish translation #16632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello! I've noticed something unusual when checking this PR:
Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits. |
Co-authored-by: José Antonio Verde <[email protected]>
Co-authored-by: Sebastiaan Speck <[email protected]>
Co-authored-by: Sebastiaan Speck <[email protected]>
Co-authored-by: Sebastiaan Speck <[email protected]>
Please do not force push. It erases history. |
I just rebased the branch so it stayed on top of main's HEAD, but ok, I won't do it again. |
It's nice to know what edits were made after what comments. If you want to update a branch, use the buttons that appear in the github UI. |
I did use them, I selected the "Update with rebase" option. |
Ah, I see. I meant that Update Branch button that appears below the comment section here if the branch is outdated. I did't know other types existed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said earlier, this is not the correct syntax.
Oh, I see it now. The other review confused me... So, as they're compulsory "enumerated" options (you have to select one or the other, but not both), you have to use the |
Co-authored-by: Managor <[email protected]>
Co-authored-by: Managor <[email protected]>
Co-authored-by: Managor <[email protected]>
Co-authored-by: Managor <[email protected]>
Correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
I don't know why the |
common
,linux
,osx
,windows
,sunos
,android
, etc.