Skip to content

Logs write to log directory instead of data directory #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tlecomte merged 1 commit into from
Aug 4, 2025
Merged

Logs write to log directory instead of data directory #345

tlecomte merged 1 commit into from
Aug 4, 2025

Conversation

@Robin-K-Lynn
Copy link
Contributor

@Robin-K-Lynn Robin-K-Lynn commented Aug 3, 2025

No description provided.

@tlecomte
Copy link
Owner

tlecomte commented Aug 4, 2025

Thanks @Robin-K-Lynn, the change makes sense.
I guess this code dates back to a time when user_log_dir did not exist in platformdirs, or whatever library we were using before that

@tlecomte tlecomte merged commit cdcaf03 into tlecomte:master Aug 4, 2025
4 checks passed
@Robin-K-Lynn Robin-K-Lynn deleted the log-directory branch August 4, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Robin-K-Lynn @tlecomte