fix(wasm): use patched sharded-slab with manual thread state release#1050
Open
themighty1 wants to merge 1 commit intomainfrom
Open
fix(wasm): use patched sharded-slab with manual thread state release#1050themighty1 wants to merge 1 commit intomainfrom
themighty1 wants to merge 1 commit intomainfrom
Conversation
Member
Author
|
To follow up on the mattermost discussion. The actual patch is located here https://github.com/tlsnotary/sharded-slab/blob/5dd1d23d5b1f57e52b1858cb3c42ef4748062f3b/src/tid.rs#L18 What this patch does NOT do:
What this patch DOES:
I additionally checked just in case that:
|
Member
Author
|
@sinui0 , ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR patches a transitive dep
sharded-slabin order to allow our wasm build to manually call destructors of objects in thread-local storage.Fixes: #959
Depends on tlsnotary/tlsn-utils#73
Tested by running the wasm prover 100+ times (whereas before it would panic on the 8th run).