Conversation
tomato42
reviewed
May 27, 2025
| ## TLS 1.2 | ||
| The schemes defined in this document MUST NOT be used in TLS 1.2 {{RFC5246}}. | ||
| The schemes defined in this document MUST NOT be used in TLS 1.2 {{RFC5246}} | ||
| or earlier versions. |
Contributor
There was a problem hiding this comment.
technically speaking, there is no way to use signature_algorithms in TLS 1.1 or earlier, so it's not possible to use those schemes and still have a standard-following implementation...
also, TLS 1.1 is deprecated: RFC8996
(not saying it's wrong to have this, but I don't think omitting it is wrong either)
Collaborator
Author
There was a problem hiding this comment.
Agreed—SignatureScheme is a TLS 1.3 type anyway, right? So TLS 1.2 is perhaps also superfluous.
Contributor
There was a problem hiding this comment.
not really, the TLS 1.3 specification allows use of the RSA-PSS signatures in TLS 1.2, and they are defined as SignatureScheme's only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.