fix: Invalid schema error when using zero arguments tools #1451
+74
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tools with no parameters (zero-argument tools) were incorrectly rejected by Google AI and Vertex AI providers with 'expected to find a map of properties' error. This fix allows tools with type 'object' but no 'properties' field to be valid. Changes: - Updated convertSchemaRecursive in googleai.go to allow empty properties for top-level object schemas instead of returning an error - Updated convertTools in vertex.go to make properties optional and validate the type only when properties field exists - Added unit tests for zero-argument tools in both googleai_unit_test.go and vertex_unit_test.go - Updated existing test case to verify zero-argument tools work correctly Fixes tmc#1446 Signed-off-by: majiayu000 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #1446 by allowing tools with no parameters (zero-argument tools) in Google AI and Vertex AI providers.
Changes
Context
Previously, tools with type object but no properties field would fail with error: expected to find a map of properties. This is a common pattern for functions that take no arguments (e.g., get_current_time).
This matches the fix implemented in langchainjs for the same issue: langchain-ai/langchainjs#8219
Generated with Claude Code