Collection of updates #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
tmcgilchrist
left a comment
tmcgilchrist
left a comment
There was a problem hiding this comment.
Looks good, thanks @MisterDA
Not sure what is happening with the Windows builds.
tmcgilchrist
requested changes
Oct 19, 2025
Owner
tmcgilchrist
left a comment
tmcgilchrist
left a comment
There was a problem hiding this comment.
Switch the CI formatting setup so it works with 5.3 for now. Once ocamlformat works with 5.4 we can revert it.
tmcgilchrist
approved these changes
Oct 24, 2025
Owner
tmcgilchrist
left a comment
tmcgilchrist
left a comment
There was a problem hiding this comment.
Looks good, the windows failures are on the lab cli tests.
If you want to fix those, it should be enough to request cmdliner help with plain output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of updates. Also fix #100.
About Remove dependency on tls: my guess is that you're depending on this transitively through whatever, like conduit or cohttp. Why is did it need an upper bound? let the dependency be dealt with cohttp. Maybe we could set an opam deptops instead?