Remove accidental set -x debug tracing#156
Open
Marcel-Bich wants to merge 1 commit intotmux-plugins:masterfrom
Open
Remove accidental set -x debug tracing#156Marcel-Bich wants to merge 1 commit intotmux-plugins:masterfrom
Marcel-Bich wants to merge 1 commit intotmux-plugins:masterfrom
Conversation
The set -x on line 3 was introduced in commit 05a4a82 (2015) during systemd support development and was never removed. It causes all commands to be traced to stderr during plugin initialization. With terminal emulators that process stderr output from tmux run-shell commands differently (e.g. Kitty with xterm-kitty terminfo), this debug output can trigger monitor-activity hooks, creating a feedback loop that results in exponential process spawning and 100% CPU usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
set -xbash debug flag fromcontinuum.tmuxline 3 that was accidentally left in since commit 05a4a82 (2015-11-23).Problem
The
set -xflag causes every command executed during plugin initialization to be traced to stderr. While this is harmless with most terminal emulators, it creates a feedback loop with terminals that handlerun-shellstderr output differently (notably Kitty withxterm-kittyterminfo):set -xgenerates stderr output during plugin operationsmonitor-activityflagsrun-shellcommands)Fix
Remove the single
set -xline. No functional changes -- this line only enables debug tracing that was part of the systemd support development in 2015.Testing
set -x: CPU returns to normal idle levels