Adopt grep -P to improve matches#135
Open
oblitum wants to merge 2 commits intotmux-plugins:masterfrom
Open
Conversation
- Fix support for matching quotes in URLs - Don't match whitespace before file paths - grep -P is needed
oblitum
force-pushed
the
fix-matching
branch
from
6bff53a to
10b6438
Compare
oblitum
force-pushed
the
fix-matching
branch
from
10b6438 to
3aa39e8
Compare
Contributor
Author
|
Dunno why that single test fails on Travis, the test's match with message works on my machine. I've tried these changes on Linux and macOS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves one of the issues I've commented at:
I'm finally getting this all fixed! Locally at least :)