Remove 'cat -' from logging pipe-pane command#68
Open
pahindman wants to merge 1 commit intotmux-plugins:masterfrom
Open
Remove 'cat -' from logging pipe-pane command#68pahindman wants to merge 1 commit intotmux-plugins:masterfrom
pahindman wants to merge 1 commit intotmux-plugins:masterfrom
Conversation
The cat is unnecessary since tmux can pipe directly to ansifilter/sed (or any other program that reads from stdin). If ansifilter/sed weren't being used then cat would be necessary, because pipe-pane needs a command to send the output to.
Author
|
I'm really liking this plugin! This is the first of a few small changes in my fork that I'd like to contribute. Thanks! |
Author
|
Hi @bruno-, do you have any feedback about this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cat is unnecessary since tmux can pipe directly to ansifilter/sed (or any other program that reads from stdin). If ansifilter/sed weren't being used then cat would be necessary, because pipe-pane needs a command to send the output to.