Open
Conversation
|
any reason this isn't being merged? |
sainnhe
reviewed
Aug 10, 2021
| for interface in /sys/class/net/*; do | ||
| interfaces+=$(echo $(basename $interface) " "); | ||
| done | ||
| if [[ -n is_osx ]] |
There was a problem hiding this comment.
This if statement is always true because -n is used to determine if the length of a string is zero.
The correct statement should be if is_osx.
I did a quick fix sainnhe@2e94ad2, you can merge my commit if you would like to.
There was a problem hiding this comment.
I tried if [[ is_osx ]] and it works well!
|
Can we have a final version merged? |
|
I guess the maintainer left? Anyone wants to take the mantle? |
Rizhiy
approved these changes
Jan 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've implemented macOS support using netstat.